Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/ukmmap: Register madvise to syscall_shim #162

Closed
wants to merge 1 commit into from
Closed

lib/ukmmap: Register madvise to syscall_shim #162

wants to merge 1 commit into from

Conversation

mogasergiu
Copy link
Member

Register madvise system call to syscall_shim library.

Signed-off-by: Sergiu Moga sergiu.moga@protonmail.com

@mogasergiu
lib/ukmmap: Register madvise to syscall_shim
fa349d9 
Register `madvise` system call to syscall_shim library.

Signed-off-by: Sergiu Moga <sergiu.moga@protonmail.com>
@nderjung nderjung added lib/ukmmap new/syscall New syscall or registration lib/syscall_shim area/lib Internal Unikraft Microlibrary area/exportsyms Issue or PR relates to exporting symbols from a library labels Apr 7, 2021
@unikraft-bot
Copy link
Member

✅ Checkpatch passed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request and it all looks good!

SHA commit checkpatch
fa349d9 lib/ukmmap: Register `madvise` to syscall_shim ✅

@razvand razvand requested a review from laurbrb April 9, 2021 12:34
laurbrb
laurbrb approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@laurbrb laurbrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sergiu,

Looks good to me.

Reviewed-by: Laurentiu Barbulescu lrbarbulescu@gmail.com

unikraft-bot pushed a commit that referenced this pull request Apr 15, 2021
@mogasergiu @unikraft-bot
lib/ukmmap: Register madvise to syscall_shim
43717f0 
Register `madvise` system call to syscall_shim library.

Signed-off-by: Sergiu Moga <sergiu.moga@protonmail.com>
Reviewed-by: Laurentiu Barbulescu <lrbarbulescu@gmail.com>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Pull-Request: #162
razvand pushed a commit to unikraft-upb/unikraft that referenced this pull request Apr 16, 2021
@mogasergiu @razvand
lib/ukmmap: Register madvise to syscall_shim
4f97204 
Register `madvise` system call to syscall_shim library.

Signed-off-by: Sergiu Moga <sergiu.moga@protonmail.com>
Reviewed-by: Laurentiu Barbulescu <lrbarbulescu@gmail.com>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Pull-Request: unikraft#162
@nderjung nderjung added the ci/merged Merged by CI label May 3, 2021
@nderjung nderjung added this to the v0.6 - Dione milestone May 3, 2021
@nderjung nderjung added this to Done in General Kanban May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurbrb laurbrb laurbrb approved these changes

Assignees
No one assigned
Labels
area/exportsyms Issue or PR relates to exporting symbols from a library area/lib Internal Unikraft Microlibrary ci/merged Merged by CI lib/syscall_shim lib/ukmmap new/syscall New syscall or registration
Projects
Unikraft Core Roadmap
Status: ✅ Done!
General Kanban
  
Done
v0.6 Dione
Status: merged
Milestone
v0.6.0 (Dione)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mogasergiu @unikraft-bot @laurbrb @nderjung