Solved some compilation warnings #281

RaduMantu · 2021-09-04T14:42:07Z

Prerequisite checklist

Read the contribution guidelines regarding submitting new changes to the project;
Tested your changes against relevant architectures and platforms;
Ran the checkpatch.pl on your commit series before opening this PR;
Updated relevant documentation.

Base target

Architecture(s): x86_64
Platform(s): kvm
Application(s): N/A

Description of changes

Fixed 4 compilation warnings for core libraries:

returning uninitialized value in fputc()
missing return statement in sync()
added cast to unsigned long for address in ioctl()
replaced implicit declaration of getpid() when libc-style stubs are not generated

nderjung

Hi @RaduMantu! Thanks for the PR and great work again at USoC21!

To get this PR ready to be merged, please can you adjust each commit message so that it:

each commit has a short title, starting with the library prefix, e.g. lib/vfscore: ;
that the line-length of each commit message is no longer than 75 chars;
put the full description within the commit message after the title.

Thanks!

RaduMantu · 2021-11-03T17:43:47Z

Hi @nderjung,

Sorry for the long delay in dealing with these issues.
I've addressed the problems that you pointed out. My fault for not using checkpatch.pl beforehand.

I'll take a look over the other pending PR tomorrow at the latest.

Thanks for taking the time!

craciunoiuc

Hey @RaduMantu,

All things look good. I was able to reproduce the warnings and fix them with your commits.

The only problem is that the second dcb5db6 and the third 358e27d commit were fixed in the meantime by @skuenzer in the same fashion.
As such, there is a merge conflict. Simply removing the second and third conflict should fix the problem.
After you do this, I will add the tag and it will get merged.

Sorry your patches weren't accepted sooner. I think people just got caught up with other stuff 🙁

Cezar

Signed-off-by: Radu Mantu <andru.mantu@gmail.com>

Replaced implicit declaration of getpid() (when no libc-style wrappers are generated) with uk_syscall_r_getpid(). Signed-off-by: Radu Mantu <andru.mantu@gmail.com>

RaduMantu · 2021-11-22T14:56:42Z

Hi @craciunoiuc ,

Thanks for the feedback.

Simply removing the second and third conflict should fix the problem.

I removed them both. Should not be any more conflicts.

Sorry your patches weren't accepted sooner. I think people just got caught up with other stuff slightly_frowning_face

It's ok. These are pretty small changes and I get they aren't a priority. Also, I could have responded quicker to change requests :/

I also looked over your comments on the other PR and will address them first thing tomorrow morning.

craciunoiuc · 2021-11-22T16:22:24Z

Hey @RaduMantu,

All good now!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@gmail.com

craciunoiuc

Hey @RaduMantu,

All good now!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@gmail.com

unikraft-bot · 2021-11-24T12:19:15Z

✅ Checkpatch passed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request and it all looks good!

SHA	commit	checkpatch
`02a5425`	lib/nolibc: Solved use of possibly uninitialized variable	✅
`779e572`	lib/uksignal: Solved implicit declaration of getpid()	✅

craciunoiuc

All good now!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@gmail.com

nderjung

Thanks! 🐒

Approved-by: Alexander Jung a.jung@lancs.ac.uk

Signed-off-by: Radu Mantu <andru.mantu@gmail.com> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Approved-by: Alexander Jung <a.jung@lancs.ac.uk> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: #281

Replaced implicit declaration of getpid() (when no libc-style wrappers are generated) with uk_syscall_r_getpid(). Signed-off-by: Radu Mantu <andru.mantu@gmail.com> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Approved-by: Alexander Jung <a.jung@lancs.ac.uk> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: #281

Signed-off-by: Radu Mantu <andru.mantu@gmail.com> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Approved-by: Alexander Jung <a.jung@lancs.ac.uk> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: unikraft#281

Replaced implicit declaration of getpid() (when no libc-style wrappers are generated) with uk_syscall_r_getpid(). Signed-off-by: Radu Mantu <andru.mantu@gmail.com> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Approved-by: Alexander Jung <a.jung@lancs.ac.uk> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: unikraft#281

nderjung linked an issue Sep 5, 2021 that may be closed by this pull request

Clean up warnings from core build #242

Closed

nderjung added kind/maintenance usoc21 Unikraft Summer of Code 2021 labels Sep 5, 2021

nderjung added lib/nolibc Only neccessary subset of libc functionality lib/uksignal lib/vfscore VFS Core Interface labels Sep 28, 2021

nderjung requested changes Sep 28, 2021

View reviewed changes

RaduMantu force-pushed the solve_warnings branch from cc9f962 to 9de3762 Compare November 3, 2021 17:19

RaduMantu requested a review from nderjung November 6, 2021 12:23

razvand requested a review from craciunoiuc November 17, 2021 12:45

razvand added this to the v0.6 - Dione milestone Nov 17, 2021

craciunoiuc requested changes Nov 20, 2021

View reviewed changes

RaduMantu added 2 commits November 22, 2021 16:38

lib/nolibc: Solved use of possibly uninitialized variable

02a5425

Signed-off-by: Radu Mantu <andru.mantu@gmail.com>

lib/uksignal: Solved implicit declaration of getpid()

779e572

Replaced implicit declaration of getpid() (when no libc-style wrappers are generated) with uk_syscall_r_getpid(). Signed-off-by: Radu Mantu <andru.mantu@gmail.com>

RaduMantu force-pushed the solve_warnings branch from 9de3762 to 779e572 Compare November 22, 2021 14:41

RaduMantu requested a review from a team November 22, 2021 14:41

razvand requested a review from craciunoiuc November 24, 2021 11:01

craciunoiuc approved these changes Nov 24, 2021

View reviewed changes

unikraft-bot assigned hlef Nov 26, 2021

razvand removed request for a team and nderjung November 27, 2021 09:24

razvand assigned nderjung and unassigned hlef Nov 27, 2021

razvand requested review from nderjung and craciunoiuc November 27, 2021 11:32

craciunoiuc approved these changes Nov 27, 2021

View reviewed changes

nderjung approved these changes Nov 27, 2021

View reviewed changes

unikraft-bot closed this Nov 27, 2021

unikraft-bot added the ci/merged Merged by CI label Nov 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solved some compilation warnings #281

Solved some compilation warnings #281

RaduMantu commented Sep 4, 2021 •

edited

nderjung left a comment

RaduMantu commented Nov 3, 2021

craciunoiuc left a comment

RaduMantu commented Nov 22, 2021

craciunoiuc commented Nov 22, 2021

craciunoiuc left a comment

unikraft-bot commented Nov 24, 2021

craciunoiuc left a comment

nderjung left a comment

Solved some compilation warnings #281

Solved some compilation warnings #281

Conversation

RaduMantu commented Sep 4, 2021 • edited

Prerequisite checklist

Base target

Description of changes

nderjung left a comment

Choose a reason for hiding this comment

RaduMantu commented Nov 3, 2021

craciunoiuc left a comment

Choose a reason for hiding this comment

RaduMantu commented Nov 22, 2021

craciunoiuc commented Nov 22, 2021

craciunoiuc left a comment

Choose a reason for hiding this comment

unikraft-bot commented Nov 24, 2021

craciunoiuc left a comment

Choose a reason for hiding this comment

nderjung left a comment

Choose a reason for hiding this comment

RaduMantu commented Sep 4, 2021 •

edited