plat/kvm/x86: Unify boot information storage #406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristian-vijelie
force-pushed
the
bootinfo_unification
branch
4 times, most recently
from
3618c5b
to
d08391a
Compare
unikraft-bot
added
area/plat
cristian-vijelie
force-pushed
the
bootinfo_unification
branch
from
d08391a
to
86c4950
Compare
Use our own structure to store boot information. This is needed to have a cleaner integration of other bootloaders than Multiboot, that use different structures (see Multiboot v2). Signed-off-by: cristian-vijelie <cristianvijelie@gmail.com>
cristian-vijelie
force-pushed
the
bootinfo_unification
branch
from
86c4950
to
135c584
Compare
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
mogasergiu
approved these changes
Apr 9, 2022
There was a problem hiding this comment.
Looks good.
Reviewed-by: Sergiu Moga sergiu.moga@protonmail.com
vladandrew
approved these changes
Apr 17, 2022
There was a problem hiding this comment.
Great work!
Approved-by: Vlad Badoiu vlad_andrei.badoiu@upb.ro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
x86_64kvmAdditional configuration
None
Description of changes
This PR adds Unikraft's own structure to store boot information. This is needed to have a cleaner integration of other bootloaders than Multiboot, that use different structures (see Multiboot v2).