lib/vfscore: Fix fget in flock() #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fget returns a non-zero value on error, 0 otherwise. This commit fixes the wrong check in flock, which assumes the opposite. It also takes the error value from fget. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu>
marcrittinghaus
added
area/lib
mschlumpp
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
Nice catch
Reviewed-by: Marco Schlumpp marco.schlumpp@gmail.com
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
razvand
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
All good. Thanks, @marcrittinghaus !
Approved-by: Razvan Deaconescu razvan.deaconescu@cs.pub.ro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
Additional configuration
Description of changes
fget returns a non-zero value on error, 0 otherwise. This commit fixes the wrong check in flock, which assumes the opposite. It also takes the error value from fget.