New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/syscall_shim: Add syscall
alias to uk_syscall
#755
lib/syscall_shim: Add syscall
alias to uk_syscall
#755
Conversation
The symbol is required for binaries that were compiled against a Linux musl and use musl's system call wrapper. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and it seems to work fine, I'll test it using the elf loader sometime in the next few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thank you for this!
Reviewed-by: Razvan Virtan virtanrazvan@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved-by: Razvan Deaconescu razvand@unikraft.io
The symbol is required for binaries that were compiled against a Linux musl and use musl's system call wrapper. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Virtan <virtanrazvan@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#755
The symbol is required for binaries that were compiled against a Linux musl and use musl's system call wrapper. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Virtan <virtanrazvan@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#755
Prerequisite checklist
checkpatch.pl
on your commit series before opening this PR;Base target
Additional configuration
CONFIG_LIBSYSCALL_SHIM=y
Description of changes
The symbol is required for binaries that were compiled against a Linux musl and use musl's system call wrapper.