Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/syscall_shim: Add syscall alias to uk_syscall #755

Conversation

mschlumpp
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.pl on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): N/A
  • Platform(s): N/A
  • Application(s): N/A

Additional configuration

  • CONFIG_LIBSYSCALL_SHIM=y

Description of changes

The symbol is required for binaries that were compiled against a Linux musl and use musl's system call wrapper.

The symbol is required for binaries that were compiled against a Linux
musl and use musl's system call wrapper.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
@mschlumpp mschlumpp requested a review from a team as a code owner February 9, 2023 14:09
@unikraft-bot unikraft-bot added area/lib Internal Unikraft Microlibrary lib/syscall_shim labels Feb 9, 2023
@unikraft-bot
Copy link
Member

Checkpatch passed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request and it all looks good!

SHA commit checkpatch
53a8b41 lib/syscall_shim: Add `syscall` alias to `uk_syscall`

@razvand razvand requested review from razvanvirtan and StefanJum and removed request for a team and dragosargint February 10, 2023 07:03
@razvand razvand added lang/c Issues or PRs to do with C/C++ topic/syscall Related to syscalls labels Feb 10, 2023
@razvand razvand added this to the v0.13.0 (Atlas) milestone Feb 10, 2023
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it seems to work fine, I'll test it using the elf loader sometime in the next few days.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com

Copy link
Contributor

@razvanvirtan razvanvirtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you for this!

Reviewed-by: Razvan Virtan virtanrazvan@gmail.com

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu razvand@unikraft.io

@unikraft-bot unikraft-bot added the ci/merged Merged by CI label Apr 26, 2023
StefanJum pushed a commit to unikraft-upb/unikraft that referenced this pull request Jun 5, 2023
The symbol is required for binaries that were compiled against a Linux
musl and use musl's system call wrapper.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Reviewed-by: Razvan Virtan <virtanrazvan@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: unikraft#755
razvanvirtan pushed a commit to razvanvirtan/unikraft that referenced this pull request Jun 6, 2023
The symbol is required for binaries that were compiled against a Linux
musl and use musl's system call wrapper.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Reviewed-by: Razvan Virtan <virtanrazvan@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: unikraft#755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lib Internal Unikraft Microlibrary ci/merged Merged by CI lang/c Issues or PRs to do with C/C++ lib/syscall_shim topic/syscall Related to syscalls
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

5 participants