kvm/x86: Add pristine ECTX check #897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
requested review from
razvanvirtan and
rares-miculescu
and removed request for
a team
razvand
added
area/lib
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
unikraft-bot
added
area/arch
razvand
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Thanks, @mschlumpp. I tested it, it works. I looked through the code and commits. Everything is OK.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
skuenzer
reviewed
Jun 1, 2023
rares-miculescu
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
I tested it and it works here too. Thanks!
Reviewed-by: Rares Miculescu miculescur@gmail.com
This can be used in situtations where the executed code must not touch the extended registers. For example, interrupt handlers in Unikraft do save these and therefore also cannot modify them. Doing so is usually breaking the interrupted code. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
This checks that the extended registers were not modified within the interrupt service routine. This is not free and therefore can be toggled via a KConfig option. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp
force-pushed
the
mschlumpp/feature/ectx-assertion
branch
from
6498935
to
e8c8342
Compare
skuenzer
approved these changes
Aug 9, 2023
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
This checks that the extended registers were not modified within the interrupt service routine. This is not free and therefore can be toggled via a KConfig option. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
x86_64kvmAdditional configuration
CONFIG_UKPLAT_ISR_ECTX_ASSERTIONS=yDescription of changes
Currently, interrupt handlers could silently modify the values of extended context registers. More recent compilers are more likely to generate vectorized machine code that utilizes these registers. This happened in the past and usually caused hard to find bugs.
This pull request implements a check on x86/kvm, but can be extended for other architectures/platforms.