lib/vfscore: Improve and fix trace point format #899
Conversation
razvand
requested review from
Starnox and
eduardvintila
and removed request for
a team
razvand
added
lib/vfscore
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
|
@mschlumpp, you mention Also, see the |
The interpolation happens in the post-processing phase (Python). Therefore, we are limited in the format strings what Python supports. |
mschlumpp
force-pushed
the
mschlumpp/fix/vfscore-tracing
branch
from
f75a5ba
to
5d285fd
Compare
There was a problem hiding this comment.
Looks good to me!
Reviewed-by: Eduard-Florin Mihailescu mihailescu.eduard@gmail.com
There were multiple issues with the format string used in the trace points. For example, python, which is used to interpret the resulting trace files, does not support the `%p` specifier, and we instead have to use `%x`. Also, we can make use of the alternate format (e.g. `%#x`) to ensure the hexadecimal numbers have a `0x` prefixed. Some format strings also did not use the correct number of arguments. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp
force-pushed
the
mschlumpp/fix/vfscore-tracing
branch
from
5d285fd
to
b178c16
Compare
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
Additional configuration
CONFIG_LIBVFSCORE=yDescription of changes
There were multiple issues with the format string used in the trace points. For example python, which is used to interpret the resulting trace files, doesn not support the
%pspecifier and we instead have to use%x. Also we can make use of the alternate format (e.g.%#x) to ensure the hexadecimal numbers have a0xprefixed. Some format strings also did not use the correct amount of arguments.