Refactor the ACPI code and change its location.

[mogasergiu]

Prerequisite checklist

• Read the contribution guidelines regarding submitting new changes to the project;
• Tested your changes against relevant architectures and platforms;
• Ran the checkpatch.pl on your commit series before opening this PR;
• Updated relevant documentation.

Base target

• Architecture(s): x86_64
• Platform(s): kvm
• Application(s): N/A

Additional configuration

Description of changes

Re-write the ACPI structures definitions and, since ACPI is platform and architecture agnostic, move it to a location where it reflects that.

This PR depends on #772 #848 #908 #909 and #910, therefore it includes them.

NOTE

This is part of a larger set of Pull Requests. To make things easier and to ensure that things build as expected, it is recommended that testing is done based on #912, which includes everything. The splitting has been done to ease the review process.

[unikraft-bot]

⚠️ Checkpatch passed with warnings

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request but it encountered warnings:

SHA	commit	checkpatch
3eb565a	plat/common/x86: Re-define ACPI structures	✅
fb7e0b5	plat/common/x86/acpi.c: Generalize checksum verification	✅
de63164	plat/common/include/x86/acpi: Move `MADT` definition to sdt.h	✅
c1e0d1a	plat/common/acpi: Generalize `ACPI` initialization code	✅
31d9268	plat/common/bootinfo: Add `UEFI` System Tables address in `bootinfo`	✅
3b72ca1	plat/common/acpi: Allow getting `RSDP` through `UEFI` System Table	⚠️
dbb6cce	plat/common/x86: Add the `FADT` among the fetched tables	✅
e925cbc	plat: Move everything `ACPI` to a platform common location	✅

Truncated logs starting from first warning 3b72ca1:

WARNING:LONG_LINE: line over 80 characters
#46: FILE: plat/common/x86/acpi.c:154:
+	ct_count = ((struct uk_efi_sys_tbl *)bi->efi_st)->number_of_table_entries;

total: 0 errors, 1 warnings, 82 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/tmp/build/a53d4c5b/patches/0006-plat-common-acpi-Allow-getting-RSDP-through-UEFI-Sys.patch has style problems, please review.

NOTE: Ignored message types: ASSIGN_IN_IF FILE_PATH_CHANGES NEW_TYPEDEFS OBSOLETE

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

---

View complete logs | Learn more about Unikraft's coding style and contribution guidelines.

[mschlumpp]

I currently can't compile this without also enabling PIE:

In file included from unikraft/lib/ukdebug/include/uk/assert.h:40,
                 from unikraft/plat/common/x86/lcpu.c:38:
unikraft/plat/common/x86/lcpu.c: In function ‘lcpu_arch_mp_init’:
unikraft/plat/common/x86/lcpu.c:216:19: error: ‘x86_start16_addr’ undeclared (first use in this function)
  216 |         UK_ASSERT(x86_start16_addr < 0x100000);
      |                   ^~~~~~~~~~~~~~~~
unikraft/include/uk/arch/lcpu.h:53:43: note: in definition of macro ‘unlikely’
   53 | #define unlikely(x) (__builtin_expect((!!(x)), 0))
      |                                           ^
unikraft/plat/common/x86/lcpu.c:216:9: note: in expansion of macro ‘UK_ASSERT’
  216 |         UK_ASSERT(x86_start16_addr < 0x100000);
      |         ^~~~~~~~~
unikraft/plat/common/x86/lcpu.c:216:19: note: each undeclared identifier is reported only once for each function it appears in
  216 |         UK_ASSERT(x86_start16_addr < 0x100000);
      |                   ^~~~~~~~~~~~~~~~
unikraft/include/uk/arch/lcpu.h:53:43: note: in definition of macro ‘unlikely’
   53 | #define unlikely(x) (__builtin_expect((!!(x)), 0))
      |                                           ^
unikraft/plat/common/x86/lcpu.c:216:9: note: in expansion of macro ‘UK_ASSERT’
  216 |         UK_ASSERT(x86_start16_addr < 0x100000);
      |         ^~~~~~~~~
unikraft/plat/common/x86/lcpu.c:217:43: error: ‘x86_start16_begin’ undeclared (first use in this function)
  217 |         memcpy((void *)x86_start16_addr, &x86_start16_begin, X86_START16_SIZE);
      |                                           ^~~~~~~~~~~~~~~~~
unikraft/plat/common/x86/lcpu.c:217:62: error: ‘X86_START16_SIZE’ undeclared (first use in this function)
  217 |         memcpy((void *)x86_start16_addr, &x86_start16_begin, X86_START16_SIZE);
      |                                                              ^~~~~~~~~~~~~~~~
unikraft/plat/common/x86/lcpu.c: In function ‘lcpu_arch_post_start’:
unikraft/plat/common/x86/lcpu.c:255:40: error: ‘x86_start16_addr’ undeclared (first use in this function)
  255 |                         apic_send_sipi(x86_start16_addr, lcpu->id);
      |                                        ^~~~~~~~~~~~~~~~

The defconfig:

CONFIG_PLAT_KVM=y
CONFIG_UKPLAT_MEMRNAME=y
CONFIG_UKPLAT_LCPU_MAXCOUNT=2
CONFIG_PAGING=y
CONFIG_LIBISRLIB=y
CONFIG_LIBSYSCALL_SHIM=y
CONFIG_LIBUKBOOT_BANNER_POWEREDBY_U8ANSI2=y
CONFIG_LIBUKCPIO=y
CONFIG_LIBUKDEBUG_PRINTK_INFO=y
CONFIG_LIBUKDEBUG_PRINTD=y
CONFIG_LIBUKDEBUG_PRINT_THREAD=y
CONFIG_LIBUKDEBUG_ANSI_COLOR=y
CONFIG_LIBUKDEBUG_TRACEPOINTS=y
CONFIG_LIBUKDEBUG_ALL_TRACEPOINTS=y
# CONFIG_LIBUKLIBPARAM is not set
CONFIG_LIBUKNETDEV=y
CONFIG_LIBUKNOFAULT=y
CONFIG_LIBVFSCORE=y
CONFIG_LIBVFSCORE_AUTOMOUNT_ROOTFS=y
CONFIG_OPTIMIZE_NONE=y

[mschlumpp]

Reviewed-by: Marco Schlumpp marco@unikraft.io

[razvand]

Approved-by: Razvan Deaconescu razvand@unikraft.io