-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch/x86: Introduce NMI event for x86 #920
Conversation
This allows libraries to handle NMI interrupts. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
@mschlumpp, this is OK with me. I'll wait for @mogasergiu's and @RaduNiculae's review, and then I'll do the final approval step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Reviewed-by: Sergiu Moga sergiu@unikraft.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved-by: Razvan Deaconescu razvand@unikraft.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Prerequisite checklist
checkpatch.uk
on your commit series before opening this PR;Base target
x86_64
kvm
Additional configuration
Description of changes
This allows libraries to handle NMI interrupts.