Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/x86: Introduce NMI event for x86 #920

Closed

Conversation

mschlumpp
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): x86_64
  • Platform(s): kvm
  • Application(s): N/A

Additional configuration

Description of changes

This allows libraries to handle NMI interrupts.

This allows libraries to handle NMI interrupts.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
@mschlumpp mschlumpp requested review from a team as code owners May 30, 2023 09:48
@unikraft-bot
Copy link
Member

Checkpatch passed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request and it all looks good!

SHA commit checkpatch
3439353 arch/x86: Introduce NMI event for x86

@unikraft-bot unikraft-bot added arch/x86_64 area/arch Unikraft Architecture area/plat Unikraft Patform lang/c Issues or PRs to do with C/C++ plat/kvm Unikraft for KVM labels May 30, 2023
@razvand razvand requested review from cristian-vijelie, mogasergiu and RaduNiculae and removed request for a team and craciunoiuc May 31, 2023 04:29
@razvand razvand added this to the v0.14.0 (Prometheus) milestone May 31, 2023
@razvand razvand removed the request for review from cristian-vijelie May 31, 2023 07:25
@razvand
Copy link
Contributor

razvand commented Jun 1, 2023

@mschlumpp, this is OK with me. I'll wait for @mogasergiu's and @RaduNiculae's review, and then I'll do the final approval step.

Copy link
Member

@mogasergiu mogasergiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Reviewed-by: Sergiu Moga sergiu@unikraft.io

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu razvand@unikraft.io

Copy link

@RaduNiculae RaduNiculae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nderjung nderjung assigned razvand and unassigned marcrittinghaus Aug 7, 2023
@unikraft-bot unikraft-bot added the ci/merged Merged by CI label Aug 7, 2023
@mschlumpp mschlumpp deleted the mschlumpp/feature/nmi-event branch August 9, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch/x86_64 area/arch Unikraft Architecture area/plat Unikraft Patform ci/merged Merged by CI lang/c Issues or PRs to do with C/C++ plat/kvm Unikraft for KVM
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

7 participants