plat/drivers/virtio: Fix missing lcpu.h include #925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an #include of <uk/plat/lcpu.h> which provides `ukplat_lcpu_disable_irq()` and `ukplat_lcpu_enable_irq()`, that are used by `virtio_blkdev_queue_cleanup_requests()`. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
unikraft-bot
added
area/plat
mariasfiraiala
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Thanks for the fix, works good.
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
RaduNichita
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Works good also on my side.
Reviewed-by: Radu Nichita radunichita99@gmail.com
razvand
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change adds an #include of <uk/plat/lcpu.h> which provides
ukplat_lcpu_disable_irq()andukplat_lcpu_enable_irq(), that are used byvirtio_blkdev_queue_cleanup_requests().Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
N/A