lib/ukdebug: Add LVLC_THREAD macro
#929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `LIBUKDEBUG_PRINT_THREAD` is selected in the configuration menu and `LIBUKDEBUG_ANSI_COLOR` is not, a build error is thrown because the `LVLC_THREAD` macro is not set. Fix this by setting the macro to an empty string if `LIBUKDEBUG_ANSI_COLOR` is not set. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
added
lib/ukdebug
lang/c
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
Starnox
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Works as expected!
Reviewed-by: Eduard-Florin Mihailescu mihailescu.eduard@gmail.com
4 tasks
mariasfiraiala
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
All good, what a pity @StefanJum found this first...
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
|
@razvand Let's merge this long awaited PR! |
razvand
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
LIBUKDEBUG_PRINT_THREADis selected in the configuration menu andLIBUKDEBUG_ANSI_COLORis not, a build error is thrown because theLVLC_THREADmacro is not set.Fix this by setting the macro to an empty string if
LIBUKDEBUG_ANSI_COLORis not set.You can replicate the crash by enabling
ukdebug -> Show thread identifierand making sureukdebug -> Colored outputis not selected in themenuconfig.Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;