plat/linuxu: Add fpsimd source file to build system #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `CONFIG_FPSIMD`, the `fp_arm64.c` source file should be added to the build. Currently this is only done for `kvm`, so trying to build anything for `linuxu` will fail with undefined references to the `fpsimd_*_state` functions. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
added
plat/linuxu
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
RaduNichita
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
It looks good to me, thanks @StefanJum!
Reviewed-by: Radu Nichita radunichita99@gmail.com
razvand
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
CONFIG_FPSIMD, thefp_arm64.csource file should be added to the build. Currently this is only done forkvm, so trying to build anything forlinuxuwill fail with undefined references to thefpsimd_*_statefunctions.Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;