lib/ukschedcoop: Keep track of thread execution times
#965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michpappas
requested changes
Jul 4, 2023
unikraft-bot
added
area/include
mogasergiu
requested changes
Jul 28, 2023
`__nsec` and `__snsec` are defined as 64-bit integers based on `__u64` and `__s64`. Depending on the target architecture, these data types are based on either `long` or `long long`. The time conversion macros, such as `ukarch_time_nsec_to_sec()`, did not strictly adhere to the data type definition, as some basic constants were defined as `UL`, while others were defined as `ULL`, resulting in promotion to `long long` when the architecture used `long` for 64-bit values. Although `long long` is effectively treated as a 64-bit integer by `gcc`, the compiler still issues a warning for mismatched integer types when the print format definitions `__PRInsec` and `__PRIsnec` are used and a promotion had occurred. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
This commit extends `struct uk_thread` with a field for keeping track of the execution time of a thread. Checkpatch-Ignore: SPLIT_STRING Signed-off-by: Simon Kuenzer <simon@unikraft.io>
This commit introduces an implementation for tracking thread execution time with minimal execution overhead. On every scheduler call (`uk_sched_yield()`), the execution time of the current thread is updated. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
I did not really forget 😇 but I added something now. |
With the intention for accessing metrics (like thread execution time), this commit introduces an interface to return a reference to the idle thread. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
This commit implements the callback for `uk_sched_idle_thread()` for `lib/ukschedcoop`. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
skuenzer
force-pushed
the
skuenzer/cputime
branch
from
77c1553
to
38b3c61
Compare
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
michpappas
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Looks good, thanks.
Reviewed-by: Michalis Pappas michalis@unikraft.io
mogasergiu
approved these changes
Aug 9, 2023
razvand
approved these changes
Aug 9, 2023
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
This commit extends `struct uk_thread` with a field for keeping track of the execution time of a thread. Checkpatch-Ignore: SPLIT_STRING Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #965
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
This commit introduces an implementation for tracking thread execution time with minimal execution overhead. On every scheduler call (`uk_sched_yield()`), the execution time of the current thread is updated. Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #965
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
With the intention for accessing metrics (like thread execution time), this commit introduces an interface to return a reference to the idle thread. Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #965
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
This commit implements the callback for `uk_sched_idle_thread()` for `lib/ukschedcoop`. Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #965
|
This broke the build on See: https://github.com/unikraft/unikraft/actions/runs/5808848506/job/15746476437#step:5:3954 |
It's not related to this pr. Since this commit was merged in |
|
You're right, i just saw this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base target
Additional configuration
CONFIG_LIBUKSCHED=yCONFIG_LIBUKSCHEDCOOP=yDescription of changes
This PR introduces keeping track of thread execution times with
lib/schedcoopand is implemented with minimal overhead. An interface for returning theidlethread enables CPU utilization computations by putting thread execution times in relation over a time window.