arch/x86_64: Paging code - Enclose params of function-like macros in brackets #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
added
area/arch
razvand
requested changes
Jul 24, 2023
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
RaduNichita
suggested changes
Jul 30, 2023
There was a problem hiding this comment.
Nice work, @cppstef
Please sign off with your real email address in the commit message. For now, it is something default, provided by Github.
You can find more information here about how to do that.
Enclose parameters of function-like macros in brackets in x86_64 paging code to avoid potential unwanted operator precedence consequences after macro expansion. Signed-off-by: Cosmin Popa <cosmin7popa@gmail.com>
RaduNichita
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
All good from my side.
Reviewed-by: Radu Nichita radunichita99@gmail.com
flpostolache
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
Looks good to me. Thank you!
Reviewed-by: Florin Postolache florin.postolache.of@gmail.com
razvand
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement in paging code: enclosed params of function-like macros in brackets to account for expressions that mess with operator precedence where the param is used within the macro.