plat/kvm/arm64: Firecracker support on arm64 #989

michpappas · 2023-07-24T04:51:06Z

Prerequisite checklist

Read the contribution guidelines regarding submitting new changes to the project;
Tested your changes against relevant architectures and platforms;
Ran the checkpatch.uk on your commit series before opening this PR;
Updated relevant documentation.

Base target

Architecture(s): [arm_64]
Platform(s): [kvm]
Application(s): [N/A]

Additional configuration

Enables using CONFIG_KVM_VMM_FIRECRACKER on arm64.

Description of changes

This PR enables Firecracker support on arm64. It introduces a set of boot pagetables for Firecracker and updates Config.uk to allow using CONFIG_KVM_VMM_FIRECRACER on arm64. Remaining work such as the linux boot probotol on arm64 and ns16550 are handled on depending PRs.

GitHub-Depends-On: #988
GitHub-Depends-On: #986
GitHub-Depends-On: #985
GitHub-Depends-On: #912

zhxj9823 · 2023-07-26T04:36:29Z

plat/kvm/arm/firecracker_bpt64.S

+
+/* ------------------- Memory Map of Firecracker on Arm64 -----------------
+ *
+ * 0x0000000000000000 - 0x0000000007ffffff	Devices:     0 -    2GiB


2GiB should correspond to 0x000000007fffffff instead of 0x0000000007fffff.

Thanks, fixed

mogasergiu

Minor repetitive comments for you to lose your sanity 🐕‍🦺.

mogasergiu · 2023-08-11T17:11:43Z

plat/kvm/include/kvm-arm64/image.h

@@ -6,7 +6,11 @@
 #ifndef __KVM_ARM64_IMAGE_H__
 #define __KVM_ARM64_IMAGE_H__

+#if defined(CONFIG_KVM_VMM_QEMU)


Now that Simon mentioned it. Maybe we can just go with #if?

Yes will fix thanks

mogasergiu · 2023-08-11T17:12:43Z

plat/kvm/arm/qemu_bpt64.S

+
+#include <arm/arm64/pagetable.S>
+
+#include <arch/reloc.h>


I believe it should be uk/reloc.h now

mogasergiu · 2023-08-11T17:13:20Z

plat/kvm/arm/firecracker_bpt64.S

+	ur_pte  arm64_bpt_l2_pt511, PTE_TYPE_TABLE
+#else
+	pte_zero	, 1
+#endif /* CONFIG_PAGING */


!CONFIG_PAGING

mogasergiu · 2023-08-11T17:13:36Z

plat/kvm/arm/firecracker_bpt64.S

+	ur_pte  arm64_bpt_l2_pt0, PTE_TYPE_TABLE
+	ur_pte  arm64_bpt_l2_pt1, PTE_TYPE_TABLE
+	pte_zero	, 509
+#ifdef CONFIG_PAGING


Ditto for #if

mogasergiu · 2023-08-11T17:13:49Z

plat/kvm/arm/firecracker_bpt64.S

+arm64_bpt_l2_pt1:
+	pte_fill	0x0000008000000000, 512, 2, PTE_BLOCK_NORMAL_RW
+
+#ifdef CONFIG_PAGING


mogasergiu · 2023-08-11T17:14:16Z

plat/kvm/arm/qemu_bpt64.S

+	ur_pte  arm64_bpt_l2_pt511, PTE_TYPE_TABLE
+#else
+	pte_zero	, 1
+#endif /* CONFIG_PAGING */


!CONFIG_PAGING

mogasergiu · 2023-08-11T17:14:40Z

plat/kvm/arm/qemu_bpt64.S

+	pte_zero	, 509
+#ifdef CONFIG_PAGING
+	ur_pte  arm64_bpt_l2_pt511, PTE_TYPE_TABLE
+#else


/* CONFIG_PAGING */ 🐶

mogasergiu · 2023-08-11T17:15:05Z

plat/kvm/arm/firecracker_bpt64.S

+	pte_zero	, 509
+#ifdef CONFIG_PAGING
+	ur_pte  arm64_bpt_l2_pt511, PTE_TYPE_TABLE
+#else


/* CONFIG_PAGING */ 🦤

Sorry meant with an ! of course 🤓 ☝️

EDIT: No, I am dumb it's fine 🤦‍♂️ 😆

mogasergiu · 2023-08-11T17:15:19Z

plat/kvm/arm/qemu_bpt64.S

+arm64_bpt_l2_pt1:
+	pte_fill	0x0000008000000000, 512, 2, PTE_BLOCK_DEVICE_nGnRE
+
+#ifdef CONFIG_PAGING


Ditto for #if

mogasergiu · 2023-08-11T17:15:37Z

plat/kvm/arm/qemu_bpt64.S

+	ur_pte  arm64_bpt_l2_pt0, PTE_TYPE_TABLE
+	ur_pte  arm64_bpt_l2_pt1, PTE_TYPE_TABLE
+	pte_zero	, 509
+#ifdef CONFIG_PAGING


mogasergiu

FC, meet the superior architecture! 💪

Reviewed-by: Sergiu Moga sergiu@unikraft.io

razvand

Approved-by: Razvan Deaconescu razvand@unikraft.io

The memory map of Firecracker on Arm64 is: 0x0000000000000000 - 0x000000007fffffff Devices: 0 - 2GiB 0x0000000080000000 - 0x000000ffffffffff DRAM: 2GiB - 1024GiB https://github.com/firecracker-microvm/firecracker 441fc98a src/vmm/src/arch/aarch64/layout.rs Signed-off-by: Michalis Pappas <michalis@unikraft.io>

Signed-off-by: Michalis Pappas <michalis@unikraft.io>

Signed-off-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #989

unikraft-bot · 2023-08-11T20:12:41Z

✅ Checkpatch passed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request and it all looks good!

SHA	commit	checkpatch
`97a4187`	plat/kvm/arm: Add pagetables for Firecracker	✅
`a24c625`	plat/kvm: Enable Firecracker on arm64	✅

michpappas requested review from a team as code owners July 24, 2023 04:51

michpappas requested review from mogasergiu and zhxj9823 July 24, 2023 04:52

razvand assigned marcrittinghaus Jul 24, 2023

razvand removed request for a team July 24, 2023 06:12

razvand added this to the v0.14.0 (Prometheus) milestone Jul 24, 2023

razvand added area/plat Unikraft Patform plat/kvm Unikraft for KVM kind/proposal arch/arm64 labels Jul 24, 2023

unikraft-bot added arch/arm arch/x86_64 area/arch Unikraft Architecture area/include Part of include/uk area/kconfig Part of the Unikraft KConfig option system area/lib Internal Unikraft Microlibrary labels Jul 24, 2023

unikraft-bot added area/makefile Part of the Unikraft Makefile build system lang/c Issues or PRs to do with C/C++ lang/python Issues or PRs to do with Python lib/ukboot plat/common Common to all platforms plat/driver plat/driver/gic plat/driver/virtio plat/xen Unikraft for Xen labels Jul 24, 2023

michpappas mentioned this pull request Jul 25, 2023

plat/drivers: Provide a single API for UART drivers #986

Draft

4 tasks

zhxj9823 reviewed Jul 26, 2023

View reviewed changes

razvand assigned razvand and unassigned marcrittinghaus Aug 11, 2023

michpappas force-pushed the arm64_firecracker branch from 72c063d to 8d84cfb Compare August 11, 2023 17:05

mogasergiu requested changes Aug 11, 2023

View reviewed changes

michpappas force-pushed the arm64_firecracker branch 2 times, most recently from a236474 to 79d924c Compare August 11, 2023 17:40

mogasergiu approved these changes Aug 11, 2023

View reviewed changes

razvand approved these changes Aug 11, 2023

View reviewed changes

razvand requested a review from zhxj9823 August 11, 2023 19:59

michpappas added 2 commits August 11, 2023 22:01

plat/kvm: Enable Firecracker on arm64

a24c625

Signed-off-by: Michalis Pappas <michalis@unikraft.io>

michpappas force-pushed the arm64_firecracker branch from 79d924c to a24c625 Compare August 11, 2023 20:01

unikraft-bot closed this in 65aac2e Aug 11, 2023

unikraft-bot added the ci/merged Merged by CI label Aug 11, 2023

nderjung added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plat/kvm/arm64: Firecracker support on arm64 #989

plat/kvm/arm64: Firecracker support on arm64 #989

michpappas commented Jul 24, 2023

zhxj9823 Jul 26, 2023

michpappas Aug 11, 2023

mogasergiu left a comment

mogasergiu Aug 11, 2023

michpappas Aug 11, 2023

mogasergiu Aug 11, 2023

mogasergiu Aug 11, 2023

mogasergiu Aug 11, 2023

mogasergiu Aug 11, 2023

mogasergiu Aug 11, 2023

mogasergiu Aug 11, 2023

mogasergiu Aug 11, 2023

mogasergiu Aug 11, 2023 •

edited

Loading

mogasergiu Aug 11, 2023

mogasergiu Aug 11, 2023

mogasergiu left a comment

razvand left a comment

unikraft-bot commented Aug 11, 2023


		#include <arm/arm64/pagetable.S>

		#include <arch/reloc.h>

plat/kvm/arm64: Firecracker support on arm64 #989

plat/kvm/arm64: Firecracker support on arm64 #989

Conversation

michpappas commented Jul 24, 2023

Prerequisite checklist

Base target

Additional configuration

Description of changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mogasergiu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mogasergiu Aug 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mogasergiu left a comment

Choose a reason for hiding this comment

razvand left a comment

Choose a reason for hiding this comment

unikraft-bot commented Aug 11, 2023

mogasergiu Aug 11, 2023 •

edited

Loading