lib/vfscore: Correct behavior of utime(NULL) #993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
requested review from
Starnox,
fabianpatras and
calex257
and removed request for
a team
razvand
added
area/lib
Starnox
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Works as expected
Reviewed-by: Eduard-Florin Mihailescu mihailescu.eduard@gmail.com
eduardvintila
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
All good on my side.
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
razvand
approved these changes
Aug 7, 2023
Previously, as a placeholder behavior, utime(NULL) would set the file times to the epoch (1970-01-01 00:00 -0000) instead of the current time. This change corrects this oversight, bringing the syscall in line with expected and documented behavior. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/utime-null
branch
from
b1009e3
to
55e94f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously, as a placeholder behavior, utime(NULL) would set the file times to the epoch (1970-01-01 00:00 -0000) instead of the current time. This change corrects this oversight, bringing the syscall in line with expected and documented behavior.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
Test with: