lib/vfscore: Add unlinkat syscall #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
requested review from
DeliaPavel and
adinamariav
and removed request for
a team
razvand
added
kind/enhancement
14 tasks
DeliaPavel
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
Looks good to me!
Reviewed-by: Delia Pavel delia_maria.pavel@stud.acs.upb.ro
razvand
approved these changes
Aug 7, 2023
adinamariav
approved these changes
Aug 7, 2023
Unikraft was previously missing an implementation of `unlinkat`, a syscall often used by modern runtimes and libcs in lieu of the older `unlink` and `rmdir` for deleting files and directories. This change provides an implementation of `unlinkat` based off existing syscalls, in the same vein as other `*at` syscalls. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Unikraft was previously missing an implementation of
unlinkat, a syscall often used by modern runtimes and libcs in lieu of the olderunlinkandrmdirfor deleting files and directories. This change provides an implementation ofunlinkatbased off existing syscalls, in the same vein as other*atsyscalls.Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target