Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit settings and vignette update #8

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Fit settings and vignette update #8

merged 8 commits into from
Mar 18, 2024

Conversation

djmannion
Copy link
Collaborator

  • Fits sigma via log sigma internally.
  • Fits sigma_e via the log of the scaling factor of sigma internally.
  • Scales the parameters to a common scale within the fitting algorithm.
  • Increases the maximum number of potential optimiser iterations.
  • Updates the vignette to warn about long runtimes and to encourage checking of the optimiser convergence value.
  • Changed packageVersion to utils::packageVersion in plot.R because check() was complaining.
  • Updated the plot test images, likely due to changes in the fitting generating different estimates.
  • Minor stylr changes.

Copy link
Collaborator

@mariadelmarq mariadelmarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks very sensible, thanks heaps!

@mariadelmarq mariadelmarq merged commit dff7ffd into master Mar 18, 2024
5 checks passed
@mariadelmarq mariadelmarq deleted the optim_settings branch March 18, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants