Jittering etc. #9
Conversation
|
Had to upgrade my R dependencies locally to get the plot tests to match. |
| #' of fits is `n + 1` (because the un-jittered start points are also fit). | ||
| #' * `prop`: The maximum jitter offset, as a proportion of the start | ||
| #' value (default of 0.5). | ||
| #' * `seed`: Seed for the random jitter generator (default is unseeded). |
There was a problem hiding this comment.
Question: what does it mean for the default to be unseeded? Is it that it chooses a random seed, that is not saved or displayed in any way, or something else?
There was a problem hiding this comment.
Never mind, I answered it below :)
|
|
||
| seed <- ifelse( | ||
| is.na(seed), | ||
| sample.int(n = .Machine$integer.max, size = 1), |
There was a problem hiding this comment.
Here's my answer to the above!
|
@djmannion Should we be incrementing the minor to 0.2.0 for this release? |
I wasn't sure if there was anything else you wanted to add for a 0.2.0 release so kept this branch at 'development'. |
|
But I think it certainly warrants bumping up to 0.2.0 irrespective of any other changes. |
Adds jittering to the fits, with updates to the article and the addition of a changelog.