Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data types docs, fix dtype bug at DF level #1178

Merged
merged 9 commits into from May 7, 2023
Merged

Conversation

cosmicBboy
Copy link
Collaborator

Fixes #1058

This PR adds docs to explain in more detail how data type validation works and interacts with the other parts of the pandera schema. It also fixes a bug in DataFrameSchema(dtype=...) where the type validation would occur if no column schemas as specified.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.54 🎉

Comparison is base (547aff1) 96.68% compared to head (3e58633) 97.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
+ Coverage   96.68%   97.23%   +0.54%     
==========================================
  Files          65       65              
  Lines        5042     5067      +25     
==========================================
+ Hits         4875     4927      +52     
+ Misses        167      140      -27     
Impacted Files Coverage Δ
pandera/api/pandas/container.py 99.25% <ø> (ø)
pandera/backends/pandas/container.py 98.31% <100.00%> (+0.08%) ⬆️
pandera/engines/engine.py 98.18% <100.00%> (+7.09%) ⬆️
pandera/engines/pandas_engine.py 95.44% <100.00%> (+3.70%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy merged commit a057df0 into main May 7, 2023
41 checks passed
@cosmicBboy cosmicBboy deleted the dtypes-docs branch May 7, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain the distinction between different engines dtypes
1 participant