Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pydantic v2 #1253

Merged
merged 25 commits into from
Aug 26, 2023
Merged

support pydantic v2 #1253

merged 25 commits into from
Aug 26, 2023

Conversation

cosmicBboy
Copy link
Collaborator

Fixes #1250, #1245

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage: 96.00% and project coverage change: +0.10% 🎉

Comparison is base (eda9a2e) 93.82% compared to head (f6512f4) 93.92%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
+ Coverage   93.82%   93.92%   +0.10%     
==========================================
  Files          90       91       +1     
  Lines        6704     6766      +62     
==========================================
+ Hits         6290     6355      +65     
+ Misses        414      411       -3     
Files Changed Coverage Δ
pandera/api/pyspark/model.py 72.07% <ø> (-0.32%) ⬇️
pandera/api/pandas/model.py 93.01% <87.50%> (+0.50%) ⬆️
pandera/typing/fastapi.py 91.48% <94.28%> (+8.73%) ⬆️
pandera/api/pandas/array.py 100.00% <100.00%> (ø)
pandera/api/pandas/container.py 99.30% <100.00%> (+0.01%) ⬆️
pandera/config.py 100.00% <100.00%> (ø)
pandera/engines/__init__.py 100.00% <100.00%> (ø)
pandera/engines/engine.py 97.27% <100.00%> (-0.91%) ⬇️
pandera/engines/pandas_engine.py 95.33% <100.00%> (-0.12%) ⬇️
pandera/engines/utils.py 100.00% <100.00%> (ø)
... and 1 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy closed this Jul 15, 2023
@cosmicBboy cosmicBboy reopened this Jul 15, 2023
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@@ -101,10 +101,11 @@ jobs:
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
pandas-version: ["1.3.0", "1.5.2", "2.0.1"]
pandas-version: ["1.5.3", "2.0.3"]
pydantic-version: ["1.10.11", "2.0.2"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some good bugfixes in pydnatic 2.1.0 (https://docs.pydantic.dev/latest/changelog/#v210-2023-07-25), should we bump this to the latest release (2.1.1) to incorporate that?

@cosmicBboy cosmicBboy mentioned this pull request Aug 16, 2023
@niraveen
Copy link

niraveen commented Aug 22, 2023

@Samreay Is there a time frame for the release of Pandera with Pydantic V2 support?

@cosmicBboy
Copy link
Collaborator Author

@niraveen aiming for a release in first week of October

@cosmicBboy cosmicBboy merged commit 850dcf8 into main Aug 26, 2023
62 checks passed
@cosmicBboy cosmicBboy deleted the pydantic-v2 branch August 26, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandera schemas incompatibility with pydantic v2
3 participants