Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move black config to pyproject.toml #1292

Merged

Conversation

nathanjmcdougall
Copy link
Contributor

Since black's line length of 79 is configured in pre-commit-config, this is somewhat inconvenient when using black directly from the command line (rather than using pre-commit).

Personally, I use VS Code, and the ms-python.black-formatter extension is not configured to use pre-commit. I like to run the formatter on-save, but at the moment it is assuming the black default line length of 88.

So, I propose moving the configuration into its own dedicated space in pyproject.toml.

Signed-off-by: Nathan McDougall <nmcdougall@tonkintaylor.co.nz>
Signed-off-by: Nathan McDougall <nmcdougall@tonkintaylor.co.nz>
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c1f9863) 93.82% compared to head (7cf375e) 93.82%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1292   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files          90       90           
  Lines        6704     6704           
=======================================
  Hits         6290     6290           
  Misses        414      414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review August 7, 2023 16:43
Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nathanjmcdougall 🙏

@cosmicBboy cosmicBboy merged commit eda9a2e into unionai-oss:main Aug 14, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants