Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise_warning -> new SchemaWarning not UserWarning #1298

Merged
merged 7 commits into from
Aug 26, 2023

Conversation

nathanjmcdougall
Copy link
Contributor

#1297

The new SchemaWarning is a subclass of UserWarning, so I think this means it shouldn't cause too many backward compatibility issues. I have added some tests that check the old behaviour still works.

Signed-off-by: Nathan McDougall <nmcdougall@tonkintaylor.co.nz>
Signed-off-by: Nathan McDougall <nmcdougall@tonkintaylor.co.nz>
Signed-off-by: Nathan McDougall <nmcdougall@tonkintaylor.co.nz>
Signed-off-by: Nathan McDougall <nmcdougall@tonkintaylor.co.nz>
Signed-off-by: Nathan McDougall <nmcdougall@tonkintaylor.co.nz>
Signed-off-by: Nathan McDougall <nmcdougall@tonkintaylor.co.nz>
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c1f9863) 93.82% compared to head (30716ab) 93.82%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1298   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files          90       90           
  Lines        6704     6705    +1     
=======================================
+ Hits         6290     6291    +1     
  Misses        414      414           
Files Changed Coverage Δ
pandera/api/checks.py 98.52% <ø> (ø)
pandera/api/hypotheses.py 100.00% <ø> (ø)
pandera/backends/pandas/builtin_checks.py 95.52% <ø> (ø)
pandera/backends/pandas/base.py 100.00% <100.00%> (ø)
pandera/backends/pyspark/base.py 100.00% <100.00%> (ø)
pandera/errors.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nathanjmcdougall 🚀

@cosmicBboy cosmicBboy merged commit 6c3efcc into unionai-oss:main Aug 26, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants