Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: add missing reason_code for pyspark backend #1646

Merged
merged 1 commit into from
May 31, 2024

Conversation

melvinkokxw
Copy link
Contributor

Fixes issue #1645.

Please let me know what needs to be changed/added. Thank you!

Signed-off-by: Melvin Kok <melvinkokxw@gmail.com>
@melvinkokxw
Copy link
Contributor Author

melvinkokxw commented May 15, 2024

On the note of testing, I tried to run make nox-conda as per the contributing documentation but it wasn't a valid target. I tried make nox-mamba instead and got this error:

nox > python scripts/generate_pip_deps_from_conda.py --compare
Packages ['core: typing-extensions'] defined in setup.py do not match requirements.in.
Modify environment.yml, then run 'nox -s requirements' to generate requirements.in
make: *** [nox-mamba] Error 1

This happens at the current HEAD on the main branch.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (4df61da) to head (6f3f7a4).
Report is 93 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1646       +/-   ##
===========================================
- Coverage   94.29%   83.25%   -11.04%     
===========================================
  Files          91      116       +25     
  Lines        7024     8648     +1624     
===========================================
+ Hits         6623     7200      +577     
- Misses        401     1448     +1047     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmicBboy
Copy link
Collaborator

@melvinkokxw thanks for the PR! will look into the nox-conda make target

@cosmicBboy cosmicBboy merged commit efbaa91 into unionai-oss:main May 31, 2024
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants