fix: SQLModel table model not validated #1696
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a SQLModel class with
table=True
asdtype
, schema is not validated. This is because such SQLModel classes do not validate data at init time (see here). This PR solves this by explicitly callingmodel_validate
/parse_obj
instead of instantiating the class.Minimal example (
python=3.8 sqlmodel=0.0.19 pandera=0.19.3
):Without the fix, validation succeeds while only emitting a warning from
model_dump()
:With the fix, a SchemaError is raised: