Add details in errors reporting to ease data debugging. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2020 19:56
Report the name of the columns whose type is missing.
c3-Anthony-Truchet
force-pushed
the
error-messages-1
branch
from
002faff
to
4534cdd
Compare
cosmicBboy
requested changes
Apr 4, 2020
pandera/schemas.py
Outdated
| return series_or_index.astype(self.dtype) | ||
| except TypeError as exn: | ||
| (msg,) = exn.args | ||
| exn.args = (f"{msg}, while processing {self.name or 'None'}",) |
There was a problem hiding this comment.
need to use %s or .format string formatting until pandera drops support for py3.5 #142
pandera/schemas.py
Outdated
Comment on lines
88
to
90
| missing_pandas_type = [name | ||
| for name, col in self.columns.items() | ||
| if col.pandas_dtype is None] |
There was a problem hiding this comment.
pylint error: https://travis-ci.org/github/pandera-dev/pandera/jobs/670692444#L763-L769
needs indentation like:
missing_pandas_type = [
name for name, col in self.columns.items()
if col.pandas_dtype is None
]
cosmicBboy
approved these changes
Jun 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 96.21% 96.39% +0.17%
==========================================
Files 9 15 +6
Lines 714 1277 +563
==========================================
+ Hits 687 1231 +544
- Misses 27 46 +19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.