Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/lazy-validation #207

Merged
merged 7 commits into from
May 8, 2020
Merged

feature/lazy-validation #207

merged 7 commits into from
May 8, 2020

Conversation

cosmicBboy
Copy link
Collaborator

Fixes #122

This PR adds lazy validation to schema and schema component classes. This keyword argument is passed into the validate method and is False by default. If True, the method will collect all SchemaError object that are raised during validation and raise a SchemaErrors exception.

  • SchemaError objects now contain the validated data, check object, and failure cases that gave rise the error.
  • SchemaErrors objects contain the collect schema errors raised during validation.

@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #207 into master will decrease coverage by 0.16%.
The diff coverage is 98.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   96.58%   96.42%   -0.17%     
==========================================
  Files          12       13       +1     
  Lines         996     1118     +122     
==========================================
+ Hits          962     1078     +116     
- Misses         34       40       +6     
Impacted Files Coverage Δ
pandera/hypotheses.py 86.79% <33.33%> (ø)
pandera/schemas.py 96.05% <98.66%> (-1.05%) ⬇️
pandera/checks.py 98.70% <100.00%> (ø)
pandera/decorators.py 90.90% <100.00%> (ø)
pandera/error_formatters.py 95.00% <100.00%> (-5.00%) ⬇️
pandera/error_handlers.py 100.00% <100.00%> (ø)
pandera/errors.py 100.00% <100.00%> (ø)
pandera/schema_components.py 98.40% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2071f36...6be0076. Read the comment docs.

@cosmicBboy cosmicBboy merged commit 1c0ec72 into master May 8, 2020
@cosmicBboy cosmicBboy deleted the feature/lazy-validation branch May 8, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement lazy validation: iteratively validate dataframe and report all errors
2 participants