Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Check.name in repr #265

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Use Check.name in repr #265

merged 2 commits into from
Sep 11, 2020

Conversation

JacobHayes
Copy link
Contributor

Previously Check.name could be set but was unused and the __repr__ fell back to the fn name, which isn't particularly useful for lambdas. This change uses the name argument in the repr, but keeps the same fallback, which has moved to __init__.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #265 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   96.62%   96.78%   +0.15%     
==========================================
  Files          15       15              
  Lines        1332     1491     +159     
==========================================
+ Hits         1287     1443     +156     
- Misses         45       48       +3     
Impacted Files Coverage Δ
pandera/checks.py 98.59% <100.00%> (+0.20%) ⬆️
pandera/decorators.py 90.80% <0.00%> (-1.74%) ⬇️
pandera/errors.py 100.00% <0.00%> (ø)
pandera/schema_components.py 98.97% <0.00%> (+0.56%) ⬆️
pandera/hypotheses.py 94.11% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7dcef4...e5318b3. Read the comment docs.

@cosmicBboy cosmicBboy merged commit 44a2083 into unionai-oss:master Sep 11, 2020
@JacobHayes JacobHayes deleted the patch-1 branch September 15, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants