Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flake8 & docs build check to travis #54

Merged
merged 8 commits into from
Jun 5, 2019
Merged

add flake8 & docs build check to travis #54

merged 8 commits into from
Jun 5, 2019

Conversation

mastersplinter
Copy link
Collaborator

@mastersplinter mastersplinter commented Jun 3, 2019

Updated:
This PR:

  • adds flake8 to travis.yml
  • makes flake8 only test pandera/pandera.py
  • make travis.yml use requirements.txt
  • fixes a couple of minor flake8 compliance issues
  • adds a final step to travis.yml which will error if the docs produce either an error or a warning. This is useful for two reasons:
    • it avoids introducing errors in documentation
    • autodoc/sphinx will warn about malformed docstrings in a way that flake8 doesn't always catch

to address #54 #49 #47

@mastersplinter
Copy link
Collaborator Author

The current test failures are correct (Travis is failing correctly).

A large number of these issues have changed in #50, so suggest re-running this after that PR merges.

@cosmicBboy
Copy link
Collaborator

we should fix all the lint errors resulting from adding flake8 to CI.

should probably ignore the F401 errors in the init file

@mastersplinter mastersplinter changed the title add flake8 to travis add flake8 & docs build check to travis Jun 5, 2019
@mastersplinter
Copy link
Collaborator Author

@cosmicBboy This PR is now ready for re-review.

Changes are:

  • changes flake8 to only apply to tests/ and pandera/pandera.py, not pandera's init.py.
  • adds a final step to travis.yml which will error if the docs produce either an error or a warning.
  • fixes errors so that the new flake8 and docs build checks pass successfully.

@cosmicBboy cosmicBboy merged commit de2b19d into unionai-oss:master Jun 5, 2019
@cosmicBboy cosmicBboy mentioned this pull request Jun 5, 2019
@mastersplinter mastersplinter deleted the feature/flake8_travis branch June 5, 2019 21:29
cosmicBboy pushed a commit that referenced this pull request May 12, 2023
pyspark imports to be separate from pandas & pyspark.pandas to avoid conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants