-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flake8 & docs build check to travis #54
Merged
cosmicBboy
merged 8 commits into
unionai-oss:master
from
mastersplinter:feature/flake8_travis
Jun 5, 2019
Merged
add flake8 & docs build check to travis #54
cosmicBboy
merged 8 commits into
unionai-oss:master
from
mastersplinter:feature/flake8_travis
Jun 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current test failures are correct (Travis is failing correctly). A large number of these issues have changed in #50, so suggest re-running this after that PR merges. |
we should fix all the lint errors resulting from adding flake8 to CI. should probably ignore the |
mastersplinter
changed the title
add flake8 to travis
add flake8 & docs build check to travis
Jun 5, 2019
@cosmicBboy This PR is now ready for re-review. Changes are:
|
cosmicBboy
approved these changes
Jun 5, 2019
Closed
cosmicBboy
pushed a commit
that referenced
this pull request
May 12, 2023
pyspark imports to be separate from pandas & pyspark.pandas to avoid conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated:
This PR:
flake8
totravis.yml
flake8
only testpandera/pandera.py
travis.yml
userequirements.txt
travis.yml
which will error if the docs produce either an error or a warning. This is useful for two reasons:flake8
doesn't always catchto address #54 #49 #47