exclude np.float128 type registration in MacM1 #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## dev #624 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 29 30 +1
Lines 3384 3384
=======================================
Hits 3345 3345
Misses 39 39
Continue to review full report at Codecov.
|
|
Alternatively, we could try-catch the import of sensitive dtypes (np.float256, etc) instead of hardcoding platform specificities as we did for windows and perhaps Macs M1. We could also detect missing dtypes from that line in the |
cosmicBboy
force-pushed
the
bugfix/623
branch
from
a9b94d2
to
29392c4
Compare
cosmicBboy
added a commit
that referenced
this pull request
Sep 22, 2021
* Strategies should not rely on pandas dtype aliases (#620) * add test for strategy with pandas.DatetimeTZDtype using a datetime.tzinfo * avoid coercing with string alias in strategies * support timedelta in data synthesis strats (#621) * fix multiindex error reporting (#622) * Pin pylint (#629) * bump pre-commit pylint version * pin pylint * remove setuptools pins * setup.py setuptools * add back setuptools dep * update ci build * update build * update nox build * update nox build * exclude np.float128 type registration in MacM1 (#624) * exclude np.float128 type registration in MacM1 * replace windows/mac m1 checks with float128 check * fix numpy_pandas_coercible bug dealing with single element (#626) * fix numpy_pandas_coercible bug dealing with single element * add test * remove empty case * update pylint (#630) * unpin pylint, remove setuptools constraint * bump cache * install simpleeval in noxfile * re-pin pylint * fix lint * nox uses setuptools < 58.0.0 Co-authored-by: Jean-Francois Zinque <jzinque@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#623 reports an issue with importing
np.float128in MacOS, M11 architecture. This PR may (?) address it