remove assumption from nullable strategies #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #640. This PR improves the performance of schema strategies that involve nullable fields. Instead of a 10x performance hit it's a 2x performance hit for specifying a nullable column.
Codecov Report
@@ Coverage Diff @@
## dev #641 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 30 30
Lines 3391 3389 -2
==========================================
- Hits 3352 3350 -2
Misses 39 39
Continue to review full report at Codecov.
|
3 tasks
cosmicBboy
added a commit
that referenced
this pull request
Nov 11, 2021
fixes #640. This PR improves the performance of schema strategies that involve nullable fields. Instead of a 10x performance hit it's a 2x performance hit for specifying a nullable column.
cosmicBboy
added a commit
that referenced
this pull request
Nov 11, 2021
fixes #640. This PR improves the performance of schema strategies that involve nullable fields. Instead of a 10x performance hit it's a 2x performance hit for specifying a nullable column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #640. This PR improves the performance of schema strategies that
involve nullable fields. Before, this strategy tries to find a case with at least
one null value. Loosen this assumption so that there can be null values
in a nullable field, but it's not necessary
Instead of a 10x performance hit it's a
2x performance hit for specifying a nullable column.