-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for geopandas GeometryDtype #698
Conversation
Fixes #693 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @roshcagra ! Have a few comments, but we should address the dependency issue before kicking off CI
hey @roshcagra would you mind rebasing your changes onto the |
Did when I saw the merge conflict and my pre-commit still passes, but looks like there are test failures anyways @cosmicBboy ? |
it's
Feel free to add the |
@cosmicBboy I think this is ready for a re-run! |
@cosmicBboy Ok actually this time :) |
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 98.40% 97.75% -0.65%
==========================================
Files 39 40 +1
Lines 3756 3790 +34
==========================================
+ Hits 3696 3705 +9
- Misses 60 85 +25
Continue to review full report at Codecov.
|
oof! okay we're almost there... basically we need install some of the geopandas dependencies in Windows CI https://geopandas.org/en/stable/getting_started/install.html#installing-with-pip I created a new https://github.com/pandera-dev/pandera/blob/master/docs/source/integrations.rst Basically if it isn't documented, the feature doesn't exist 😉 |
Will do!
…On Wed, Dec 15, 2021, 8:02 AM Niels Bantilan ***@***.***> wrote:
oof! okay we're almost there... basically we need install some of the
geopandas dependencies in Windows CI
https://geopandas.org/en/stable/getting_started/install.html#installing-with-pip
I created a new geopandas branch that we can merge this PR into. I can
handle the CI updates on my end, but you would you mind creating a new PR
to add documentation on the integrations page?
https://github.com/pandera-dev/pandera/blob/master/docs/source/integrations.rst
Basically if it isn't documented, the feature doesn't exist 😉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#698 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIC6E2FWWYWHNJB6UXXJUTURCGVHANCNFSM5JSLBIXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
thanks for the contribution @roshcagra, this is awesome! I'll follow up with the changes in CI |
* Add geopandas support * small tweak * linting * requirements * fixes * import variable * fin * too many ancestors * ok actually please be done * Update geopandas.py * Update geopandas.py Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com>
* Add support for geopandas GeometryDtype (#698) * Add geopandas support * small tweak * linting * requirements * fixes * import variable * fin * too many ancestors * ok actually please be done * Update geopandas.py * Update geopandas.py Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> * geopandas docs (#711) * geopandas docs * links * geopandas unit tests, more docs (#731) * ci doesn't install geopandas on windows * update strategies tests * update strategies tests * update tests * update docs * pin sphinx-autodoc-typehints=1.14.1 error in importing Literal in python 3.7 * exclude check docs from windows os build Co-authored-by: Roshan A <roshan.agrawal95@gmail.com>
* Geopandas (#732) * Add support for geopandas GeometryDtype (#698) * Add geopandas support * small tweak * linting * requirements * fixes * import variable * fin * too many ancestors * ok actually please be done * Update geopandas.py * Update geopandas.py Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> * geopandas docs (#711) * geopandas docs * links * geopandas unit tests, more docs (#731) * ci doesn't install geopandas on windows * update strategies tests * update strategies tests * update tests * update docs * pin sphinx-autodoc-typehints=1.14.1 error in importing Literal in python 3.7 * exclude check docs from windows os build Co-authored-by: Roshan A <roshan.agrawal95@gmail.com> * typed descriptors and setup.py only includes pandera (#739) * typed descriptors and setup.py only includes pandera * black * Update common.py Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> * Bugfix/734 (#735) * fix error-reporting bug for pandas==1.1.5 * add tests, add pandas 1.1.5 to CI * fix ci conditional on modin * simplify error formatting logic * Fastapi initial integration (#741) * fastapi support * wip * [wip] add pre/post_format * implement pre/post-format semantics on check_types * rename from/to format config and methods * pa.check_types uses pydantic.validate_arguments * update tests * add check_types(use_pydantic:bool) flag * rename arg to with_pydantic * add tests for format conversion * add happy path fastapi tests * fix Literal import * fix deps * remove prototyping files * fix lint * fix typing.fastapi module imports * ignore mypy errors * fix set_index with MultiIndex (#751) * strategies: correctly handle StringArray null values (#748) * strategies: correctly handle StringArray null values * handle pandas 1.1.5 and 1.4.0 errors * Add Python 3.10 to CI matrix (#724) * Add Python 3.10 to CI * Fix CI * Exclude modin tests on Python 3.10 * Exclude ray from Python 3.10 build * Exclude modin-ray from Python 3.10 build * Fix environment.yml version of ray * exclude ray from base deps installation * Update .github/workflows/ci-tests.yml * Update .github/workflows/ci-tests.yml * fix ci and setup.py * update deps * update deps, nox * update ci, noxfile * update ci * simplify nox linters * exclude geopandas in py310 * update nox * update black version * update reqs * update readthedocs py version * dont install koalas for py310 * update readthedocs py version * update deps * test readthedocs * add back ci tests * windows * update pandas version in nox * remove koalas + windows * fix ci file * ignore windows doc checks * add back other os * dont build docs for py3.10 * test ubuntu * set max parallel * try no-env * try no-env * testing * testing * get python version from sys * upgrade pip * pytest verbosity * add back cache * bump cache version * testing * testing * update * try using conda * update conda setup * update conda setup * use conda * unpin numpy * update reqs * only use conda-forge * update * update * use pip * use pip * testing * install numpy * increase cache * update * test nox * cache pip * use nox * use nox * update * testing * testing * testing * testing * testing * testing * testing * testing * testing * testing * add matrix * disable koalas in ci * update * testing * testing * testing * testing * testing * testing * use nox * use pytest * testing * clean up Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> * fastapi docs, add to ci (#753) * fastapi docs, add to ci * add data conversion docs page, sponsor button * fix lint * update requirements file * fix mypy test * update deps * fix tests * fix docs deps * update docs copy * more docs copy updates * formatting * fix yml * add title/description fields (#754) * add title/description fields * modify base config with title/desc * fix docstring * black * let SchemaModel use docstring as desc * update test_config * fix black * Update tests/core/test_model.py * fix black Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> * Pull request: Nullable float (#721) * New datatype: Panda's (ver 1.2.0+) nullable float. Documentation: https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.2.0.html?highlight=float64dtype#experimental-nullable-data-types-for-float-data * PyLint expects uppercase snake case. * fix unit test * fix docs * fix fastapi tests Co-authored-by: Vova <vladimirvilimaitis@gmail.com> Co-authored-by: cosmicBboy <niels.bantilan@gmail.com> Co-authored-by: Roshan A <roshan.agrawal95@gmail.com> Co-authored-by: Cristian Matache <cristianmatache@hotmail.com> Co-authored-by: James Myatt <james@jamesmyatt.co.uk> Co-authored-by: Sean Mackesey <s.mackesey@gmail.com> Co-authored-by: vovavili <64227274+vovavili@users.noreply.github.com> Co-authored-by: Vova <vladimirvilimaitis@gmail.com>
Adds a
DataType
forGeometryDtype
so that pandera can supportGeoDataFrame
andGeoSeries
.