Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decimal #956

Merged
merged 5 commits into from
Oct 8, 2022
Merged

Fix decimal #956

merged 5 commits into from
Oct 8, 2022

Conversation

cosmicBboy
Copy link
Collaborator

Fixes #926

This PR extends the datatype engine to convert parameterized pandera data type instances into the pandas native data type instances, which will cover the case for dtypes.Decimals, dtypes.Category, and other parameterized datatypes.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 96.68% // Head: 96.68% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ce413be) compared to base (4e9c997).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          42       42           
  Lines        4187     4195    +8     
=======================================
+ Hits         4048     4056    +8     
  Misses        139      139           
Impacted Files Coverage Δ
pandera/dtypes.py 94.93% <100.00%> (+0.19%) ⬆️
pandera/engines/engine.py 98.87% <100.00%> (+0.05%) ⬆️
pandera/engines/pandas_engine.py 96.98% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy merged commit 3063a0a into master Oct 8, 2022
@cosmicBboy cosmicBboy deleted the fix-decimal branch October 8, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check schema with Decimal not working in Pandera
1 participant