Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch taxonomic and functional information for UniProt id's #20

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

tibvdm
Copy link
Collaborator

@tibvdm tibvdm commented May 15, 2023

Endpoint that enables a user to fetch the taxonomic and functional information, given a list of UniProt identifiers.

A different tool (PathwayPilot) wants to retrieve taxonomic and functional information for both peptides and UniProt id's. Unipept already provides and endpoint for peptides (peptinfo), but not for proteins.

Since Unipept already stores an index over de UniProt accession id's, we can easily add a protinfo endpoint that contains the same information and format as its peptide counterpart. The added benefits over other endpoints are:

  • An identical format as the peptinfo endpoint. This allows end users to work with the same data, independently from
    the input.
  • Batch requests. This endpoint can process multiple UniProt id's fast, while other resources are limited and thus slower.

@tibvdm tibvdm requested a review from pverscha May 15, 2023 13:19
Copy link
Member

@pverscha pverscha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@bmesuere
Copy link
Member

Can you add a little more info about why this was added?

@tibvdm
Copy link
Collaborator Author

tibvdm commented May 16, 2023

I updated the description with some extra information regarding the new endpoint.

=====

A different tool (PathwayPilot) wants to retrieve taxonomic and functional information for both peptides and UniProt id's. Unipept already provides and endpoint for peptides (peptinfo), but not for proteins.

Since Unipept already stores an index over de UniProt accession id's, we can easily add a protinfo endpoint that contains the same information and format as its peptide counterpart. The added benefits over other endpoints are:

  • An identical format as the peptinfo endpoint. This allows end users to work with the same data, independently from
    the input.
  • Batch requests. This endpoint can process multiple UniProt id's fast, while other resources are limited and thus slower.

=====

Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I would also add public docs to the unipept website

@pverscha pverscha merged commit 2c663f9 into develop Jun 14, 2023
2 checks passed
@pverscha pverscha deleted the feature/protinfo-endpoint branch June 14, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants