Add unit tests #53
Merged
Add unit tests #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmesuere
requested changes
Mar 11, 2021
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
bmesuere
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Jest unit tests and a GitHub action that will automatically be executed after each push. Visual snapshots are used in this package to make sure that the appearance of visualizations didn't change due to an update. Note that the Treeview visualization cannot be tested using this approach at this point in time, due to lacking support for advanced SVG manipulations in JSDom (jsdom/jsdom#2531).
The GitHub action also creates an artefact that can be downloaded, which contains all screenshots produced and all screenshot diffs if a test failed. Annotations that point to which line in the source code caused a failure are also automatically added.