-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for element ID gets overwritten #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, the id isn't necessary anymore and can be removed entirely.
ID's are no longer being used now :) |
@@ -952,7 +949,7 @@ export default class Heatmap { | |||
private initTooltip() { | |||
return d3.select("body") | |||
.append("div") | |||
.attr("id", this.element.id + "-tooltip") | |||
.attr("id", Math.floor(Math.random() * 2**16) + "-tooltip") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think id's must start with a letter according to the spec
If an element ID is already set, the visualization should not overwrite it. This PR provides a fix for the bug reported in #55.