Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ pass props to inject function #3

Merged
merged 2 commits into from
Jan 13, 2018
Merged

✨ pass props to inject function #3

merged 2 commits into from
Jan 13, 2018

Conversation

fabienjuif
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 76.667% when pulling a41593b on props-to-inject into e3520dd on master.

@fabienjuif
Copy link
Member Author

Hm we should find a way to test update

  • from parent props
  • from mutation in store

delphinemillet
delphinemillet reviewed Jan 11, 2018
View reviewed changes
package.json
@@ -1,6 +1,6 @@
{
"name": "k-mobx-react",
"version": "0.1.0",
"version": "0.1.4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this jump from 0 to 4 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because we can't use yarn link right now I have to dig this topic: mobxjs/mobx#1082 (comment)

@fabienjuif fabienjuif merged commit 235a6db into master Jan 13, 2018
@fabienjuif fabienjuif deleted the props-to-inject branch January 13, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delphinemillet delphinemillet delphinemillet approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabienjuif @coveralls @delphinemillet