Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo should ignore things to do in lib directory? #3641

Open
pchiusano opened this issue Nov 29, 2022 · 1 comment
Open

todo should ignore things to do in lib directory? #3641

pchiusano opened this issue Nov 29, 2022 · 1 comment

Comments

@pchiusano
Copy link
Member

I think yes: you can always cd lib if you specifically want to see whether your dependencies are curret wrt a patch.

.distributed.topics.baseupdate> todo lib.base_new.patch

  馃毀
  
  The namespace has 30 transitive dependent(s) left to upgrade. Your edit frontier is the
  dependents of these definitions:
  
    lib.base.time.Instant.internal.dayOfYearToMonthAndDay : Boolean -> Nat -> (Nat, Nat)
    lib.base.time.Instant.atOffset                        : Instant -> UTCOffset -> OffsetDateTime
    lib.base.time.OffsetDateTime.toInstant                : OffsetDateTime -> Instant
    lib.base.Bytes.indexOf                                : base.Bytes
                                                            -> base.Bytes
                                                            -> Optional Nat
  
  I recommend working on them in the following order:
  
  1. lib.base.time.Instant.internal.dayOfYearToMonthAndDay.doc : Doc
  2. lib.base.time.OffsetDateTime.toInstant.doc                : Doc
  3. lib.base.time.Instant.doc                                 : Doc
  4. lib.base.time.Instant.atUTC                               : Instant -> OffsetDateTime
  5. lib.base.time.LocalTime.doc                               : Doc
  6. lib.base.Bytes.doc                                        : Doc
  7. lib.base.time.Instant.atOffset.doc                        : Doc
  8. lib.base.time.OffsetDateTime.toInstant.tests.rountrip     : [test.Result]
  9. lib.base.time.Instant.toText                              : Instant -> Text
  10. lib.base.time.OffsetDateTime.toText.doc                   : Doc
  11. lib.base.Bytes.indexOf.doc                                : Doc
  
@pchiusano pchiusano transferred this issue from unisonweb/ui-core Nov 29, 2022
@hojberg hojberg added the on-deck label Dec 1, 2022
@mitchellwrosen
Copy link
Member

A question about this one.

Say we have a library foo with terms

lib.foo.a
lib.foo.b

where lib.foo.a is a dependency of lib.foo.b:

lib.foo.b = lib.foo.a + 100

And our own library function src.barbo is a dependency of lib.foo.b:

src.barbo = lib.foo.b * 4

Furthermore, say we have a patch thepatch that records an update of lib.foo.a to some newer version.

lib.foo.a -> lib.foo.a#newhash

I think the idea behind this ticket is: if I ask todo thepatch, don't tell me that lib.foo.b needs an update, because that's library code that I'm not meant to touch.

But our src.barbo is a transitive dependent of something on the LHS of thepatch (namely lib.foo.a), it's just not on the "edit frontier" of direct dependents.

Do we want to recommend the user starts working through definitions beginning with src.barbo, ignoring all dependents of edited definitions that only have names in lib.*?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants