Compile errors in TermSearchboxParser.hs during editor build

[atacratic]

I hit the following compile errors when running stack --stack-yaml editor.yaml build.

It looks like they might have been introduced in #70 and I guess not fixed by #71 but I'm not sure. Paging @refried anyway if he can take a look?

...
unison-editor-0.1: build
Completed 28 action(s).

--  While building package unison-editor-0.1 using:
      /home/vagrant/.stack/setup-exe-cache/x86_64-linux/setup-Simple-Cabal-1.22.4.0-ghcjs-0.2.0.20151001_ghc-7.10.2 --builddir=.stack-work/dist/x86_64-linux/Cabal-1.22.4.0_ghcjs build lib:unison-editor exe:editor --ghc-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1
    Logs have been written to: /vagrant/.stack-work/logs/unison-editor-0.1.log

    Configuring unison-editor-0.1...
    Preprocessing library unison-editor-0.1...
    [1 of 8] Compiling Unison.TermSearchboxParser ( src/Unison/TermSearchboxParser.hs, .stack-work/dist/x86_64-linux/Cabal-1.22.4.0_ghcjs/build/Unison/TermSearchboxParser.js_o )

    /vagrant/editor/src/Unison/TermSearchboxParser.hs:34:10:
        Couldn't match expected type ‘Parser String’
                    with actual type ‘(Char -> Bool) -> Parser String’
        Probable cause: ‘takeWhile’ is applied to too few arguments
        In the expression: takeWhile Char.isDigit
        In an equation for ‘digits’: digits = takeWhile Char.isDigit

    /vagrant/editor/src/Unison/TermSearchboxParser.hs:34:20:
        Couldn't match type ‘Char -> Bool’ with ‘[Char]’
        Expected type: String
          Actual type: Char -> Bool
        Probable cause: ‘Char.isDigit’ is applied to too few arguments
        In the first argument of ‘takeWhile’, namely ‘Char.isDigit’
        In the expression: takeWhile Char.isDigit

    /vagrant/editor/src/Unison/TermSearchboxParser.hs:46:29:
        Couldn't match expected type ‘Parser String’
                    with actual type ‘(Char -> Bool) -> Parser String’
        Probable cause: ‘takeWhile’ is applied to too few arguments
        In the second argument of ‘(*>)’, namely
          ‘takeWhile (\ c -> c /= '"')’
        In the first argument of ‘(<*)’, namely
          ‘char '"' *> takeWhile (\ c -> c /= '"')’

    /vagrant/editor/src/Unison/TermSearchboxParser.hs:46:40:
        Couldn't match expected type ‘Char -> Bool’
                    with actual type ‘[Char]’
        The lambda expression ‘\ c -> c /= '"'’ has one argument,
        but its type ‘String’ has none
        In the first argument of ‘takeWhile’, namely ‘(\ c -> c /= '"')’
        In the second argument of ‘(*>)’, namely
          ‘takeWhile (\ c -> c /= '"')’

[sfultong]

Thanks for bringing this to our attention.

In an effort to get a demo-able search engine POC, we've mostly been working on the topic/searchengine branch recently, and we've been editing unison code directly, so we've neglected the editor for the moment.

I'm not as familiar with the editor code, but I'll see if I can get things fixed up on master.

[atacratic]

Oh, sorry @refried, wasn't you - was due to effect blocks change. Trivial fix coming shortly...

[pchiusano]

This is fixed in topic/searchengine branch, which should get merged shortly...