-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version of systemTime that returns an Int representing microseconds #2418
Conversation
Hooray! But looks like impl just multiplies by a million, and can't actually work out the time to precision better than a second? |
My very limited understanding is that My animation code depends on it having microsecond resolution, and seems to work fine at least when rendering 30 fps, which makes me think the code is correct. But i can't claim to understand all the details :/ |
Oh magic, OK, nice one, sorry for misunderstanding! Cheers for doing this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Left a couple comments though.
Also anytime you update the builtins, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Resolves #2359
Tests pass and have used the new function successfully (i hacked the previous version for the test), but will require an update of base.
Base refers to
systemTime.impl
which is a built-in, but i'm not sure how that connects tosystemTime.impl.v3
, i'm guessing something else needs to be wired (?)