Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better diagnostics when compilation fails with missing data case #2428

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

pchiusano
Copy link
Member

@pchiusano pchiusano commented Sep 22, 2021

I've been tracking down a compilation failure with "missing data case". Still haven't managed to reproduce it more simply, but this PR adds slightly better diagnostics by telling you what Reference is involved in the failure.

@pchiusano pchiusano changed the title Added better diagnostics when compilation fails with missing data case Add better diagnostics when compilation fails with missing data case Sep 22, 2021
Copy link
Contributor

@dolio dolio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Pretty straight forward.

@pchiusano pchiusano added the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Sep 22, 2021
@mergify mergify bot merged commit 22f1587 into trunk Sep 22, 2021
@mergify mergify bot deleted the debug/missing-data-case branch September 22, 2021 17:57
@mergify mergify bot removed the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants