Code (de)serialization fixes #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* actually cache intermediate terms * don't try to load the code attached to literal terms when deseralizing terms
- Expose the internal compiler bugs as a Failure in unison
- Added some codeops tests using the new validate - Updated other transcript output for new builtins
pchiusano
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This includes a few fixes and some testing support for issues that we stumbled into while working on distributed computation support.
Code.validatebuiltin for forcing the validation ofCode, whether or not it already lives in the code cache.Code.displaybuiltin for displayingCode