use constants for Optional/Either/SeqView constructor ids #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dolio I got started (and possibly finished?) updating the runtime to use constants for the decls are vulnerable to constructor id changes.
When you have a chance, would you check and update this PR for correctness, style and naming to your liking, and any obvious runtime performance issues that I might have introduced in the smart constructors (if you keep them).
Feel free to merge once you're satisfied.
P.S. The stray trailing whitespace deletion was automatic, and too hard to fight.