Add ability to hide ucm commands until we're ready to release them. #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
commented
Mar 24, 2022
| @@ -1550,7 +1610,7 @@ help = | |||
| intercalateMap | |||
| "\n\n" | |||
| showPatternHelp | |||
| (sortOn I.patternName validInputs) | |||
| visibleInputs | |||
There was a problem hiding this comment.
The inputs are sorted in the original list, which means they'll appear in the expected order everywhere, and also means GHC will only sort the list the first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As the UCM team works on the new Share server we'll want to keep merging into trunk to avoid long-lived branches and encourage continuous integration, but it's likely a lot of these commands won't be 100% ready to ship even though they're merged, since some commands might be complete in UCM, but are waiting for a feature on the server, or perhaps we want to dogfood them for a longer period than usual.
I'll be using this so I can merge the
auth.logincommand.This change allows us to merge new commands into UCM, and for us to test them, etc; but hides them from any help output, command lists, and autocomplete so that users don't stumble into them and get confused.
Implementation notes
Adds a "visibility" parameter to Inputs, inputs which are marked has hidden won't show up in help or autocomplete.
Hidden commands can still be executed if you know the name, and you can request help for it if you know the name.