Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete old namespace references #3076

Merged
merged 6 commits into from Jun 8, 2022
Merged

Delete old namespace references #3076

merged 6 commits into from Jun 8, 2022

Conversation

albertoefg
Copy link
Contributor

Fix #2838

@plumenator
Copy link
Contributor

Not sure why this is failing CI. The error log is empty as well.

@plumenator
Copy link
Contributor

Nvm. I see the log now, was blocked by uMatrix

Alberto Flores and others added 2 commits May 23, 2022 22:57
@plumenator
Remove old references to namespace blocks
77a8f02 
Co-authored-by: Karthik Ravikanti <karthik.ravikanti@gmail.com>
@plumenator
Update ability syntax in the error message.
d91db0c 
Co-authored-by: Karthik Ravikanti <karthik.ravikanti@gmail.com>
@aryairani aryairani added the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label May 27, 2022
@pchiusano
Copy link
Member

Bounced CI, seems like maybe a spurious failure.

@pchiusano pchiusano merged commit b26090b into unisonweb:trunk Jun 8, 2022
@mergify mergify bot removed the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Jun 8, 2022
@pchiusano pchiusano mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryairani aryairani aryairani left review comments

@pchiusano pchiusano pchiusano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message references old namespace scoping functionality
4 participants
@albertoefg @plumenator @pchiusano @aryairani