Set journal mode on create rather than open. #3091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We previously set the journal mode to
WAL
every time we opened a connection, this likely because we would switch the journal mode toDELETE
when pushing to ensure the database was fully synced from the.wal
file.Since then, we've done a lot of work to ensure our codebase connections are better managed, and no longer need to set
DELETE
mode on push because we close connections correctly before pushing.Now, since we never switch away from WAL mode there's no reason to explicitly set WAL mode on every connection, and it's causing some issues in the Share server since we open the codebase for every request and setting the journal mode is requires locking the whole DB.
So, now we can just set WAL on every new codebase and assume all existing codebases are already in WAL mode.
Implementation notes