Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some array additions/fixes #3146

Merged
merged 1 commit into from Jun 22, 2022
Merged

Some array additions/fixes #3146

merged 1 commit into from Jun 22, 2022

Conversation

dolio
Copy link
Contributor

@dolio dolio commented Jun 22, 2022

  • Add 24 and 40 bit primitive reads. These are directly supported by Chez, and are convenient for base32hex coding.
  • Add size operations on builtin arrays.
  • Fix order of operations in implementations multi-byte array reads. They were shifting before promoting to a larger word size, which would just zero the values out.

@dolio
Some array additions/fixes
f0b63e7 
- Add 24 and 40 bit primitive reads. These are directly supported by
  Chez, and are convenient for base32hex coding.
- Add size operations on builtin arrays.
- Fix order of operations in implementations multi-byte array reads.
  They were shifting before promoting to a larger word size, which would
  just zero the values out.
@pchiusano pchiusano added the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Jun 22, 2022
@mergify mergify bot merged commit 89e2dfa into trunk Jun 22, 2022
@mergify mergify bot deleted the work/arrays branch June 22, 2022 19:49
@mergify mergify bot removed the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Jun 22, 2022
@pchiusano pchiusano mentioned this pull request Jul 8, 2022
Closed
@aryairani aryairani mentioned this pull request Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchiusano pchiusano pchiusano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dolio @pchiusano