-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP Mk II #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using handles isn't recommended due to weird handle close-logic.
ChrisPenner
force-pushed
the
cp/lsp-II
branch
from
September 12, 2022 16:30
c91d5a4
to
d1f232f
Compare
ChrisPenner
commented
Sep 13, 2022
@@ -38,112 +24,19 @@ uToLspPos uPos = | |||
uToLspRange :: Range.Range -> Range | |||
uToLspRange (Range.Range start end) = Range (uToLspPos start) (uToLspPos end) | |||
|
|||
infoDiagnostics :: FileAnalysis -> Lsp [Diagnostic] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than analyze the notes from scratch each time for diagnostics, we should analyze the notes once and collect all the info we can from them. So most of this logic just moved to FileAnalysis.hs
ChrisPenner
force-pushed
the
cp/lsp-II
branch
from
September 13, 2022 16:24
2cbd9b2
to
88c24ef
Compare
aryairani
approved these changes
Sep 17, 2022
Co-authored-by: Mitchell Rosen <mitchellwrosen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the following features to the Mk I release:
_hole
filleInstallation and setup
Currently the only supported configuration is to connect to the LSP via a specified port.
The default is
127.0.0.1:5757
, but you can change the port usingUNISON_LSP_PORT=1234
.I've got this configuration in my CocConfig for nvim, your setup may vary.
Note that you'll need to start UCM before you try connecting to it in your editor or your editor might give up (fixed in VS code now 😄 )
For VSCode I believe we'll have to publish an npm package to make an extension.
This change is