Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message on missing names #3227

Merged
merged 4 commits into from Jul 13, 2022
Merged

Improve error message on missing names #3227

merged 4 commits into from Jul 13, 2022

Conversation

ChrisPenner
Copy link
Contributor

Overview

Old error:

image

New error:

image

@ChrisPenner ChrisPenner self-assigned this Jul 13, 2022
@ChrisPenner ChrisPenner added this to the M4 milestone Jul 13, 2022
@pchiusano pchiusano added the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Jul 13, 2022
pchiusano
pchiusano approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@pchiusano pchiusano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pchiusano pchiusano removed the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Jul 13, 2022
@pchiusano
Copy link
Member

@ChrisPenner can we do "Your current namespace is too deep to see..."

rather than "perspective"

aryairani
aryairani approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pchiusano pchiusano added the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Jul 13, 2022
@pchiusano pchiusano merged commit 8b802c5 into trunk Jul 13, 2022
@pchiusano pchiusano deleted the cp/missing-names-error branch July 13, 2022 15:45
@mergify mergify bot removed the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Jul 13, 2022
@aryairani aryairani mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchiusano pchiusano pchiusano approved these changes

@aryairani aryairani aryairani approved these changes

@mitchellwrosen mitchellwrosen Awaiting requested review from mitchellwrosen

Assignees

@ChrisPenner ChrisPenner

Labels
None yet
Projects
None yet
Milestone
M4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisPenner @pchiusano @aryairani