Omit empty namespaces local #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
reviewed
Jul 13, 2022
aryairani
reviewed
Jul 13, 2022
unison-share-api/src/Unison/Server/Endpoints/NamespaceListing.hs
Outdated
Show resolved
Hide resolved
aryairani
reviewed
Jul 13, 2022
unison-share-api/src/Unison/Server/Endpoints/NamespaceListing.hs
Outdated
Show resolved
Hide resolved
aryairani
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
At some point during the work to get share-next up and running I'd removed the sub-namespace definition count (we didn't have any way to efficiently compute it on the server at the time),
It also removed it from share-local.
I've since re-added the functionality on the server, but hadn't yet gotten around to adding it on local.
This re-adds the defn count on local, which means 'empty' namespaces (namespaces which have a history but no definitions) won't be shown in the UI.
Implementation notes
I split the two implementations of 'namespace listing' out, and re-added logic to compute defn count on the local one.
TODO: